Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_2_X]Remove rebin from SiStripBadAPVandHotStripAlgorithm #42962

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

jlidrych
Copy link
Contributor

@jlidrych jlidrych commented Oct 6, 2023

PR description:

Backport of #42956

This PR is related to this issue.
The proposed changes should be harmless - only unnecessary re-binning is removed.

PR validation:

See #42956

Backporting:

Backport of #42956

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2023

A new Pull Request was created by @jlidrych for CMSSW_13_2_X.

It involves the following packages:

  • CalibTracker/SiStripQuality (alca)

@saumyaphor4252, @perrotta, @consuegs, @cmsbuild can you please review it and eventually sign? Thanks.
@robervalwalsh, @gbenelli, @tocheng, @mmusich, @echabert this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor

@cmsbuild please test

@perrotta
Copy link
Contributor

perrotta commented Oct 6, 2023

backport of #42956

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c2602c/35087/summary.html
COMMIT: cb3f00c
CMSSW: CMSSW_13_2_X_2023-10-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42962/35087/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198423
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198397
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@saumyaphor4252
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4e54b51 into cms-sw:CMSSW_13_2_X Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants